Giters

CUNY-CL / yoyodyne

Small-vocabulary sequence-to-sequence generation with optional feature conditioning

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature indexing

bonham79 opened this issue · comments

commented

IndexFeatures has an incorrect alignment for feature_idx. See

yoyodyne/yoyodyne/indexes.py

Line 160 in 18f19ae

return len(self.source_map) - self.features_idx

Easy fix but impacts #47 Do we want to maintain a separate features_map to ease chance of these bugs or keep merged with source_map.

commented

I don't understand the bug (why is this wrong? ) so I am assigning the issue to you---is this related to poor performance of the feature-ified transducer?

commented

The way the index is set up, 'souece_map' includes feature vocab, so this is just providing the last index of the combined vocabularies, as opposed to the start of the feature vocabularies.

This would impact all models that treat features separately

commented

@bonham79 can I close this too?