Informative model logging
kylebgorman opened this issue · comments
Right now we log both the "model" (decoder and default encoder) and the "module" (encoder) lookups here and here respectively. This gives us the following printout, for a pointer-generator with a transformer encoder layer (cf. Singer & Kann 2020):
Model: PointerGeneratorLSTMEncoderDecoder
Model: TransformerEncoder
This is not as informative as it could be. I submit it would be better as something like:
Model: transformer encoder, pointer-generator LSTM decoder
I think this could be done by adding properties to each "model" and "module" class and then concatenating them together like:
util.log_info(f"Model: {encoder.name} encoder, {model.name} decoder")
Thoughts? If this proposal appeals it should be easy for me to implement.
oh this definitely should be improved. (espeicially the pointer gnerator atm). Preffered style would be like...
Model: Pointer Generator
\ Source_Encoder: Transformer
\ Feature_Encoder: Linear
only issue is that ptl's parameter logging is really good for quickly comparing model sizes.