[Feature Request] Launch confirmation prompts
zamastyle opened this issue · comments
Some launch configurations are riskier to use than others. As a modder, it would be a huge benefit to be able to add a custom launch confirmation prompt to the launch configuration block.
When a launch configuration is selected to launch
- if there a prompt key in the configuration block
---- a confirmation modal pops up with the prompt string above a "Launch" and "Cancel" button
---- if launch, launch as usual
---- if cancel, return to launch selection menu - if there is no prompt key in the config
---- launch immediately
Being able to inform a user of the limitations or potential issues with what they are about to launch could really help prevent mistakes with new users and risky clicks.
Do not provide such to users then.
hekate's boot entries config system is built upon intention.
If something is in it that it shouldn't, it should not be there.
Intent is the key and also why various errors exist (informing user instead of just continuing unknowingly)
For example loading a kip via kip1=path/name.kip instead of kip1=path/*.
The former declares intention that you want that specifically, so it errors if missing.
The latter is load whatever exists.
And ofc for the former case you can have one boot entry that loads it and one that doesn't.
Also boot entry titles and icons exist and can describe the boot entry.
Basically, that request is for avoiding instructing users to pick one or another .ini, in which I always reply with no.
For reference, all of the above describes the scope of how hekate/Nyx functions.
Ok. I assume this would extend to rejected a PR containing this feature if I implemented it myself?
If you are gonna implement it anyway for custom builds, you may as well try to PR it.
But probably it's gonna be rejected. The reasons you gave are not enough for this, which I consider bloat.
Like what is a risky config even? There are no such things except if you are distributing malicious things.