'X has conquered Y' omitted from gossip filter menu

Question

'X has conquered Y' omitted from gossip filter menu

legdrop opened this issue 7 years ago · comments

Good afternoon, firstly, thank you very much for such a wonderful modification, which I use with the acquisition of the game.
But there is a problem - gossip on the screen about AI does not appear at all, just notifications about my studied technologies of culture and science.
How can I solve this problem? Or tell me, which file or string I should cut to get rid of the gossip removal function.
I'm playing the Russian version of the game.
Thank you very much!

Christopher Crockett · Answer 1 · Sat May 13 2017 14:18:36 GMT+0800 (China Standard Time)

This may be an issue with the heuristic used for intercepting gossips. I did my best to render it language neutral, but there's only so much I can achieve as an English-only speaker.

Hey @E1ectron, does this issue affect you as well?

Sergei Solo · Answer 2 · Sat May 13 2017 16:28:19 GMT+0800 (China Standard Time)

Sorry, I can't check it now and in the near future (don't have access to actual game version).

Sergei Solo · Answer 3 · Sat May 20 2017 06:08:32 GMT+0800 (China Standard Time)

Hey, @chaorace. Test it on a 1.0.4 (1.0.0.129) Mac version on Russian and English.
For a hour, I haven't seen any gossips. So problem is not the language.

May be platform? @legdrop, you play on Win or Mac?

legdrop · Answer 4 · Sat May 20 2017 06:53:22 GMT+0800 (China Standard Time)

Windows 10, 64 bit.

George · Answer 5 · Sat May 20 2017 07:11:00 GMT+0800 (China Standard Time)

I think @legdrop wants to read popup gossips that appear on vanilla on center of the screen. If so you need to remove line 35 in UI/Panels/StatusMessagePanel.lua that was added on this commit f04d0b5

legdrop · Answer 6 · Sat May 20 2017 16:31:45 GMT+0800 (China Standard Time)

@bolbass
Yes, you understood everything correctly, thank you all very much!
I do not have the option now to run the game, but please check, I selected the correct code to delete?

George · Answer 7 · Sat May 20 2017 19:02:20 GMT+0800 (China Standard Time)

Don't delete it :)
The commit I mentioned above was already fixed in CQUI so my last comment was wrong.

The last commits that affect gossips are c896313 and f9d919e. And this commit 6c30940 affects the size of gossip messages.
The result of these commits is that you can choose gossips you want to see or disable on CQUI settings that are above the minimap. Have you tried changing it to turn on all the gossips?
I've tested CQUI gossip settings a bit and couldn't find a gossip when other civs enter new era for example.
To see all the gossips you can also try to manually delete lines 284-293 in StatusMessagePanel.lua
On a picture above you've already selected them but first 4 lines should stay.
You should start deleting from if (type == ReportingStatusTypes.GOSSIP) then

legdrop · Answer 8 · Mon May 22 2017 01:08:54 GMT+0800 (China Standard Time)

Thanks a lot, it works!

Christopher Crockett · Answer 9 · Sat May 27 2017 07:46:12 GMT+0800 (China Standard Time)

Okay... so did we ever figure out if this issue was caused by CQUI not correctly showing gossips?

George · Answer 10 · Sat May 27 2017 13:06:12 GMT+0800 (China Standard Time)

Yes, there is at least one type of gossips that is missing on gossips settings screen (a gossip when other civs enter new era for example).

George · Answer 11 · Fri Jun 02 2017 14:34:49 GMT+0800 (China Standard Time)

This type of gossips is now under "City>>X has counquered Y" settings. We should fix it and can close this issue as soon as it's enough to unchek "Trim gossip messages" to see all the gossips. And maybe we need to edit a tooltip for this setting because it's not obvious that all gossips will be shown if we uncheck it.