CPS-IT / personio-jobs

Extension for TYPO3 CMS to integrate jobs from Personio Recruiting API

Home Page:https://extensions.typo3.org/extension/personio_jobs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Import failed

Ranunzel opened this issue · comments

commented

TYPO3 version

12.4.5

PHP version

8.1

Extension version

0.5.3

Composer mode

  • I'm running TYPO3 in composer mode.

Operating system

Linux

Current behavior

The XmlToArray failes to convert when only 1 Jobs gets imported. The nesting is wrong,

In PersonioApiService line 71

Expected behavior

No response

Steps to reproduce

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct.

In addition it would be good to remove the final from the class, to be able to fix it with an XClass, while waiting for a fix.

Hi @garbast, if you have a working XCLASS in place, feel free to submit a PR, and I'll be happy to merge it. Otherwise, I'll try to have a look at it next week.

@Ranunzel @garbast This is now fixed and covered with tests. I just released 0.5.3 containing this fix.