CPJKU / partitura

A python package for handling modern staff notation of music

Home Page:https://partitura.readthedocs.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test File paths Indexing is ambiguous

manoskary opened this issue · comments

Hello, with this issue I would like to address the way the partitura tests are handled. This issue doesn't actually concern the partitura package code but only the test handling. We've been using pre-defined paths in the tests init and indexing the files that correspond to the actual file we would like to test for each one of the unit-tests. However, adding or removing test example files can perturb this indexing and moreover, we don't always know what file we are running the test on. I propose we change all the unit-tests with another solution to remove the indices, maybe calling the files by name would be a better option.

I'm in favour of just using the local path to the file. It will make things much easier. However, we need to find a solution for the tests that run on a larger set of scores, like the load_score test. Maybe in the test init we can have a function which takes all the files divided by folder.

It will take some time, but maybe we can start fixing it for the next release (1.3.3)

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?