make_note_features with force_fixed_size and "all" features returns inconsistent features
sildater opened this issue · comments
possible bug in line 150 elif force_fixed_size and bf == "time_signature_feature":. This condition is never reached since if bf is a string the condition in line 145 if isinstance(bf, str): already catches it and if it is a functiontype (should be the case when called with `feature_functions = "all") the condition in line 150 is not true.
Nice Catch
Nice solution for the time_signature exclusion. I still get varying columns and names due to the metrical_feature, can this be caught or standardized as well? Maybe just excluded, since it's in the note_array as include_metrical_position?