automatic blackening of code might be broken

Question

automatic blackening of code might be broken

sildater opened this issue a year ago · comments

sildater commented a year ago

release 1.3.0 does not seem to be blackened. e.g. the note_features.py module has very wide lines and horizontal lists.

sildater · Answer 1 · Tue Jun 13 2023 22:48:48 GMT+0800 (China Standard Time)

and also doc string length seems to be unaffected by blacken, so we need to check this manually.

Emmanouil Karystinaios · Answer 2 · Tue Jun 13 2023 23:59:09 GMT+0800 (China Standard Time)

I just realized why it did not work....
I called the workflow to run for PR or push on master not main

Emmanouil Karystinaios · Answer 3 · Wed Jun 14 2023 00:00:03 GMT+0800 (China Standard Time)

However, I will change the workflow to run only after every push to develop instead, so that the blacken code is first previewed and stays on develop.

sildater · Answer 4 · Wed Jun 14 2023 14:59:02 GMT+0800 (China Standard Time)

Ah, yes that's a good idea!

Emmanouil Karystinaios · Answer 5 · Wed Jun 14 2023 17:54:20 GMT+0800 (China Standard Time)

The blacken now works on develop and submits a new commit with the blacken code which gains authorship from the person pushing to develop. I will leave this issue open if there are any other remarks about the blacken process, otherwise feel free to close the issue.