building with SHOW=yes entirely hides the informative build step output

Question

building with SHOW=yes entirely hides the informative build step output

bkerin opened this issue 6 years ago · comments

bkerin commented 6 years ago

It's still nice to be able to see e.g.:

*** Running [debug] cos-props_d

when SHOW=yes, changing it to output comment prefix keeps the output true (i.e. paste-and-buildable).

original, ends up hiding step descriptions when SHOW=yes (annoying):

#E := $(if $(call eq,$(SHOW),yes),@ #,@ echo)

If SHOW is yes start $E lines with comment prefix, otherwise just plain @ echo:

E := $(if $(call eq,$(SHOW),yes),@ echo '#',@ echo)

I think just putting such lines as comments would work as well and make $E unneeded so maybe there is some reason this was done that I'm not aware of.

Laurent Deniau · Answer 1 · Fri Dec 14 2018 17:57:17 GMT+0800 (China Standard Time)

If the observable behaviour is the same or better, make a PR and I will see the effective change during the approval. Thanks, Laurent. On 14 Dec 2018, at 01:40, bkerin <notifications@github.com<mailto:notifications@github.com>> wrote: It's still nice to be able to see e.g.: *** Running [debug] cos-props_d when SHOW=yes, changing it to output comment prefix keeps the output true (i.e. paste-and-buildable). original, ends up hiding step descriptions when SHOW=yes (annoying): #E := $(if $(call eq,$(SHOW),yes),@ #,@ echo) If SHOW is yes start $E lines with comment prefix, otherwise just plain @ echo: E := $(if $(call eq,$(SHOW),yes),@ echo '#',@ echo) I think just putting such lines as comments would work as well and make $E unneeded so maybe there is some reason this was done that I'm not aware of. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<#22>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABKFzxTy_z3qryg2yy1tgqI0jlQ68fMqks5u4vNggaJpZM4ZSrv_>.

…

-- Laurent Deniau http://cern.ch/mad Accelerators Beam Physics mad@cern.ch<mailto:mad@cern.ch> CERN, CH-1211 Geneva 23 Tel: +41 (0) 22 767 4647

bkerin · Answer 2 · Mon Jan 07 2019 04:43:49 GMT+0800 (China Standard Time)

This is now more or less fixed but I'm slightly unhappy with the fix as it introduces an inconsistency with the *** output format used elsewhere, I think it would be better to remove E entirely and always output # *** Whatever, hence this note-to-self

Laurent Deniau · Answer 3 · Sun Jan 08 2023 23:20:29 GMT+0800 (China Standard Time)

no follow-up for a while, closing