edbrowse does need a patch to successfully compile in Nixpkgs
AndersonTorres opened this issue · comments
Sorry by the laziness, but among other things I have noticed two or three things that hindered the building.
It fails because the variable QUICKJS_LDFLAGS is not passed to js_hello_quick target.
Maybe the traditional Linux distros install quickjs in expected places, while Nixpkgs does not. It triggered a typical linking error.
I have included a patch directly in our repositories to fix this behaviour - there is it:
(If by anything, I put this file in public domain. :P )
As an aside, I have also noticed that quickjs is not autodetected; because of it we basically made a sed edition in the makefile, but this is less important for now.
distros probably shouldn't build the hello targets, it's not in the default target and not really meant for users (but yes I mean might as well get it fixed sure)
As for quick there's no .pc or anything we could use -- on nixos the include path is set in NIX_CFLAGS_COMPILE and PATH adds quickjs../bin but it doesn't add its lib search path to NIX_LDFLAGS -- that's the problem and not something edbrowse can do anything about.
Oh, now I have seen it.
I was chasing a bug on why does it not compile, and I have found the "offending" lines above.
About the autodetection issue, I will try to contact the quickjs developers with a patch.