Giters

CIROH-UA / nwmurl

This library contains utility functions to generate National Water Model data URLs

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Retro 2.1 zarr headers bug

karnesh opened this issue · comments

commented

The nwmurl generates wrong file list for retro 2.1 zarr headers (.json files). Following input arguments:

start_date = "200701010000"
end_date = "200701010800"
urlbaseinput = 3
selected_var_types = [1]
selected_object_types = [1]  
write_to_file = False

file_list = nwmurl.generate_urls_retro(
    start_date,
    end_date,
    urlbaseinput,
    selected_object_types,
    selected_var_types,
    write_to_file
)

generates

['1.json',
 '1.json',
 '1.json',
 '1.json',
 '1.json',
 '1.json',
 '1.json',
 '1.json',
 '1.json']

instead of

['https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010100.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010101.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010102.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010103.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010104.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010105.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010106.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010107.LDASIN_DOMAIN1.json',
 'https://ciroh-nwm-zarr-retrospective-data-copy.s3.amazonaws.com/noaa-nwm-retrospective-2-1-zarr-pds/forcing/2007/2007010108.LDASIN_DOMAIN1.json']