removal of finalize()
aleqs opened this issue · comments
this is a minor thing, but it would be cleaner to either remove finalize() from BittrexExchange altogether or implement Closeable instead. i think it is expected that users can take care of resource management themselves :)
Yes, this certainly would make more sense in modern day java. I'll caught up in a few other things this coming week so hopefully get to in next week. Happy to take a PR too 😉
Just pushed this change to develop, will be in the next release
thank you, looks good!