Make revert_port non-admin?

[Naved Ansari]

Revert port is quite useful, and I don't understand why it's restricted to admin use only. I think it makes sense to make it open to people with access to nodes. In that case we might even change the API and call it revert_nic since end users perform operations on the nic rather than ports.

[Ian Denhardt]

I don't see any reason to keep it admin-only, though we'd definitely want to change it to operate on nics instead of ports. I think this is an artifact of our original intended use cases, which centered around admins setting stuff up on a switch for the first time.

[Naved Ansari]

Is there a standard way to mark an REST API deprecated? Some people are inserting the Warning header to notify. Because it would make sense to mark revert_port deprecated when we introduce revert_nic.

[Ian Denhardt]

I don't know that there's anything "standard." setting the Warning header sounds like a good idea, and we could modify the client lib and cli to log a warning header if it sees one. I'm willing to bet there's some kind of annotation for it as part of swagger, if we were to move to using that to specify the APIs, but I don't know off-hand. Quoting Naved Ansari (2019-02-20 10:38:26)

…

Is there a standard way to mark an REST API deprecated? Some people are inserting the Warning header to notify. Because it would make sense to mark revert_port deprecated when we introduce revert_nic. -- You are receiving this because you commented. Reply to this email directly, [1]view it on GitHub, or [2]mute the thread. Verweise 1. #1062 (comment) 2. https://github.com/notifications/unsubscribe-auth/AA18Pr1JJecU4MuCBQUgrhMG2RkOvYz9ks5vPWvygaJpZM4a8gte