Enhancement: UI fixes in alert dialogs
its-me-abhishek opened this issue · comments
Describe your issue
Currently, the alert dialogs throughout the app are not consistent with the app's themes and colors.
To make them more visually appealing and cohesive, we can introduce a consistent style, similar to the one in Add Task
dialog box. This way, users will have a more appealing experience across the app.
Steps to reproduce
- Save or edit projects, tasks, and tags to observe changes.
- On the Profiles page by deleting, exporting, or renaming profiles.
What was the expected result?
No response
Put here any screenshots or videos (optional)
![IMG-20240217-WA0002](https://private-user-images.githubusercontent.com/114338679/305632537-1a106c89-f7ae-413d-956c-40fa2dd43fcc.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTM3LTFhMTA2Yzg5LWY3YWUtNDEzZC05NTZjLTQwZmEyZGQ0M2ZjYy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01YjZkMzVlMTA2ZDk3YWFiZmU1ZmM2YTY4YzIyMzVjOGQwYzFjMzYxYjgzYzE1ZDgxNTlmNmI0ZjdjMTQ0YWMyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.y6IH7L1D6EtFJtcKakJVIG0ZygDBPd89bWmsv5OxYKQ)
![IMG-20240217-WA0003](https://private-user-images.githubusercontent.com/114338679/305632539-de4144d2-2e2d-4bf5-a81a-91f4d8672bd5.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTM5LWRlNDE0NGQyLTJlMmQtNGJmNS1hODFhLTkxZjRkODY3MmJkNS5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNzkyNzcyZWZjNjA4NTU0YjE4YjE3YmJkOWVhMWMwOGQ5MGUwNjgxMDE4NjFiMWFmZjI2MTQ3NWRmNGJkZTc0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Yj6D9OUHYyDoVRXSV6zVgyP-ZoOf4wL8HlkeXzo4Yas)
![IMG-20240217-WA0004](https://private-user-images.githubusercontent.com/114338679/305632543-2dc13d7c-f9eb-4530-bc0d-09ce4579849a.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTQzLTJkYzEzZDdjLWY5ZWItNDUzMC1iYzBkLTA5Y2U0NTc5ODQ5YS5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNGI0NjkwNmUzNjdkM2ZjNDI3M2M3NDYzZjBiOGExYTkwNGQwZDQ0YjU5MmZiMDczNWRhNTlhOWE3ZDdjNzExJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.CDHjIveDDDRL_DukoNMMyZKSsZun_Kya17NL6OPRQOk)
![IMG-20240217-WA0005](https://private-user-images.githubusercontent.com/114338679/305632544-f2f1f2de-b6a4-4530-986d-700edabbf1a0.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTQ0LWYyZjFmMmRlLWI2YTQtNDUzMC05ODZkLTcwMGVkYWJiZjFhMC5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yYjc4MWUyYTIyOGM4Mjc5ZjIyOTY2NmJjMThjZDZhYzkzODg4ZjViNjI1ODY2ZjEyNDczZmE5NThlMWU1ZDkxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.hjTSv5H9LFnJBmqZriRFtDJ3mkcAOsEBpYIq1AdNjbI)
![IMG-20240217-WA0006](https://private-user-images.githubusercontent.com/114338679/305632545-4dbfe54d-973c-4062-885d-47e650a94c75.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTQ1LTRkYmZlNTRkLTk3M2MtNDA2Mi04ODVkLTQ3ZTY1MGE5NGM3NS5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05NzhjOTFlMjU1ZGNkN2YxYWYwNjZmOGJhZjU3YTFjYTFjMGFiODMzMWY1MTdjMjU5MTBiZTVlZmUxYTUyMjUyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.6rnMe0grK7gKaI3_tu38XOks8lrx8dsYKWhyNUKbmDs)
![IMG-20240217-WA0007](https://private-user-images.githubusercontent.com/114338679/305632547-aebe7f69-b579-4f95-a362-6d3370a68eeb.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTQ3LWFlYmU3ZjY5LWI1NzktNGY5NS1hMzYyLTZkMzM3MGE2OGVlYi5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02NTNmMzQyYzMwYTcxZjA5ZmJkZTQxYzE0NTgzZjNlY2Q5YzhjYWM4YTM0NzhlYTI5M2FiNDIxYjFlZGIwYjRmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.xYE6fkXe-KAP4iajx5S-W14PmvCY6l0Cug8S8SbSIWA)
![IMG-20240217-WA0008](https://private-user-images.githubusercontent.com/114338679/305632548-f3321526-9037-4c99-8c5d-0c2020dd9ae7.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTQ4LWYzMzIxNTI2LTkwMzctNGM5OS04YzVkLTBjMjAyMGRkOWFlNy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1hNTcwMTliNzRhNjljY2E0MmVjYjE4ZDNlMGY2ODEwYjQwYzkyYzI0MzEzY2I5MmIzZWZkYTg1OGQ5MzUzM2Q2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.YZxeEHJxY3njmZGyiiPzty1tQQTUGJsPP7FlmgpE67s)
![IMG-20240217-WA0009](https://private-user-images.githubusercontent.com/114338679/305632550-b11964f9-dcb5-4af2-98a7-e213df80d6cc.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjExNTQwNjgsIm5iZiI6MTcyMTE1Mzc2OCwicGF0aCI6Ii8xMTQzMzg2NzkvMzA1NjMyNTUwLWIxMTk2NGY5LWRjYjUtNGFmMi05OGE3LWUyMTNkZjgwZDZjYy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcxNlQxODE2MDhaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xODI3N2MzMTM3NDdhOWY0MmI4MmVjMDI1NjU1NDExOTVkN2NkYzRmYzRiZTYxNjJmNmYyYzQ5MDdmNmJiMzk4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.2nzIdF9X9oJtR8XAtVXEXhJXRukxEhxd0YSwYKtRc6o)
How can we contact you (optional)
No response
Would you like to work on this issue?
Yes
By submitting this issue, I have confirmed that:
- I have starred the repo ⭐ and watched 👀 it on GitHub and followed the contribution guidelines.
Currently, the app's color, themes, and fonts are hardcoded, making it difficult to manage the overall theme. It would be helpful if we could create system-wide global classes to easily handle these elements. For instance, we could create a class called "TaskWarriorColors" and list all the static color values under it. This way, we could easily call the colors we need, such as TaskWarriorColors.black or TaskWarriorColors.white. The same approach could be used for fonts as well.
@its-me-abhishek you can make multiple prs and issues for that.
I think we can use extension method on alert dialog widget and create all UI designs like,be it colour or be it border radius and other elements I think it will be the most optimised code
@Pavel401 what do you think?
I think we can use extension method on alert dialog widget and create all UI designs like,be it colour or be it border radius and other elements I think it will be the most optimised code
@Pavel401 what do you think?
Discuss with @its-me-abhishek about the most effective implementation.
@its-me-abhishek instead of creating those border radius and colors in every dialog and other elements that are common,you can use extension method on alert dialog and easily use the same code again and again.what do you think and the most optimised one can be created a alert dialog util.dart and then pass the title text,call back functions and then import this in necessary files.Actually i wanted to work on this but helping other team mates can also be a great choice.what do you think @its-me-abhishek and @Pavel401
hey, major portions that are being repeated in most of the dialog boxes are the surfaceTintColor, shadowColor, backgroundColor and some text styles, instead of making a function, I've updated the main.dart
, to include a config for dialogTheme in the ThemeData, and have updated the values there.
Edit: You might make a function after the addition of FontStyles, as main.dart won't work without hot reload in Statless widgets so, we'll have to make a function anyways.