CCExtractor / beacon

Flutter application to share location with a group. (under development)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

This line is misleading as a text field

vik4114 opened this issue · comments

Is your feature request related to a problem? Please describe.
This line is misleading as a text field and if it is acting as a partition still it is not symmetric

Screenshot
Screenshot_1647773488_1

Describe the solution you'd like
I think we should remove it

Describe alternatives you've considered
-Else we can make it symmetric
-Or Bring it just below the text field

Additional context
Sol 1
Screenshot_1647773488_2

Sol2
Screenshot_1647773488_3

Are you working on this? (Yes/No)
Yes

@nb9960 What do you think?

@vik4114 afaik that line is a mere partition between the two fields and is only for UI purposes. It has nothing to do with the textfields or symmetry. It's there to only get a general idea to users for where the divide lies between them.

@ItsAdityaKSingh But without the line it looks good

I guess the same follows for the other text fields too and because UI needs to be consistent, you'll have to make the changes throughout.
Additionally, that line acted as a partition removing it doesn't look good, the latter one is still better (i.e, to add the line below the text field)

@vik4114 Are you still working on this issue?

@srockstech Yes, I was stuck with other work, I will raise pr soon.

@srockstech Yes, I was stuck with other work, I will raise pr soon.

Hi vik can i work on this if possible ??

Hey, @vik4114, are you working on resolving this?

I think no one solved this issue, so I created a PR(#170). So please check. @ItsAdityaKSingh

is this issue resolved ??
@ItsAdityaKSingh