75 locations still have no county

Question

75 locations still have no county

simonw opened this issue 3 years ago · comments

Baltimore is fixed now. Opening a separate issue for the remainder.

Originally posted by @simonw in #672 (comment)

https://vial.calltheshots.us/api/searchLocations?format=map&all=1&id=lccytm&id=lxdrt&id=lxdpt&id=lxdqq&id=lcdczb&id=lxdrd&id=lcdbpg&id=lcdbyb&id=lcdxtc&id=lxdrk&id=ltktx&id=ltqcd&id=ltxzk&id=lwgcb&id=lwzkh&id=lxbfh&id=lxdkp&id=lxdkq&id=lxdkt&id=lxdky&id=lxdkr&id=lxdkz&id=lxdmc&id=lxdmd&id=lxdmf&id=lxdmk&id=lxdpb&id=lxdmx&id=lxdmz&id=lxdpc&id=lxdpf&id=lxdmt&id=lxdpy&id=lxdpz&id=lxdpq&id=lxdpr&id=lxdmr&id=lxdpw&id=lxdqb&id=lxdqw&id=lxdqk&id=lxdqm&id=lxdqp&id=lxdrh&id=lxdqz&id=lxdrp&id=lxdrr&id=lxdrc&id=lxdrq&id=lxdqx&id=lxdqh&id=lxdrm&id=lxdqt&id=lxdqd&id=lxdqg&id=lxdrw&id=lzfxx&id=lzfxz&id=lccgbg&id=lccybd&id=lccypg&id=lxdkw&id=lxdqc&id=lxdqf&id=lxdrb&id=lxdrf&id=lxdrg&id=lxdrx&id=lxdqy&id=lxdpp&id=lxdpx&id=lccgbf&id=lcctgy&id=lzfxy&id=lxdpm&id=lxdqr is a map of them. All but one are in Washington DC (the other is in Carlsbad).

Simon Willison · Answer 1 · Thu Jun 17 2021 06:19:11 GMT+0800 (China Standard Time)

The DC ones fail like this: https://us-counties.datasette.io/counties/county_for_latitude_longitude?longitude=-77.03324&latitude=38.92956

Simon Willison · Answer 2 · Thu Jun 17 2021 06:20:17 GMT+0800 (China Standard Time)

But with a SQL query that doesn't join against STATE they work:

https://us-counties.datasette.io/counties?sql=select%0D%0A*%0D%0Afrom%0D%0A++counties%0D%0Awhere%0D%0A++within(%0D%0A++++GeomFromText(%0D%0A++++++%27POINT(%27+||+%3Alongitude+||+%27+%27+||+%3Alatitude+||+%27)%27%0D%0A++++)%2C%0D%0A++++counties.Geometry%0D%0A++)%0D%0Alimit%0D%0A++1&longitude=-77.03324&latitude=38.92956 works

https://us-counties.datasette.io/counties?sql=select%0A++STATEFP+as+state_fips%2C%0A++states.abbreviation+as+state%2C%0A++STATEFP+||+COUNTYFP+as+county_fips%2C%0A++counties.NAME+as+county_name%2C%0A++COUNTYNS%2C%0A++AFFGEOID%2C%0A++GEOID%2C%0A++LSAD%2C%0A++ALAND%2C%0A++AWATER%0Afrom%0A++counties+join+states+on+counties.STATEFP+%3D+states.fips%0Awhere%0A++within(%0A++++GeomFromText(%0A++++++%27POINT(%27+||+%3Alongitude+||+%27+%27+||+%3Alatitude+||+%27)%27%0A++++)%2C%0A++++counties.Geometry%0A++)%0Alimit%0A++1&longitude=-77.03324&latitude=38.92956 does not

Simon Willison · Answer 3 · Thu Jun 17 2021 06:21:33 GMT+0800 (China Standard Time)

And that's because DC is missing from https://us-counties.datasette.io/counties/states - FIPS code 11 has nothing. Even though other non-states such as Northern Mariana Islands are listed there.

Simon Willison · Answer 4 · Thu Jun 17 2021 06:23:07 GMT+0800 (China Standard Time)

Fixing this bug over here: simonw/us-counties-datasette#1

Simon Willison · Answer 5 · Thu Jun 17 2021 06:30:03 GMT+0800 (China Standard Time)

I've fixed the bug in the underlying API, gonna clear the task queue and try this again.

Simon Willison · Answer 6 · Thu Jun 17 2021 06:31:00 GMT+0800 (China Standard Time)

Delete all on https://vial.calltheshots.us/admin/core/task/?task_type__id__exact=5

Then:

curl -XPOST 'https://vial.calltheshots.us/api/resolveMissingCounties' -d ''

Simon Willison · Answer 7 · Thu Jun 17 2021 06:31:38 GMT+0800 (China Standard Time)

https://vial.calltheshots.us/dashboard/?sql=select+%2A+from+location+where+county_id+is+null%3AErXCiDwO3Bh5kWY28zK36s3URN-kgrCH5Jtf6NEhXM0 now comes up empty!