VTS embed doesn't have "Locations near me" like VCA does
obra opened this issue · comments
I think that's the last real feature to get to parity.
@obra i intentionally omitted it because 1) chromium browsers block geolocation api's in iframes unless the caller provides allow="geolocation" in their iframe params and 2) I just didn't view it as high value even if the caller doesn't mess up the iframe permissions.
Having said that, it wouldn't be that hard to add a custom control to the mapbox UI for using location (https://codepen.io/sergei-zelinsky/pen/gGOZjE), but I would put this in the very low priority bucket
Understood, and we can do, but the existing functionally is broken for alameda today on chrome and firefox. Safari is the only modern browser I know that lets you bypass the iframe permissions.
If we build out geolocation for the embed, we will need to communicate that you should set allow="geolocation"
URL params don't update for the embed because it's not meaningful, yeah.
ok - it's fortunately quite simple to turn that on so i can do that
Oh, sorry to let you down @obra 😅 but i was wrong, it's actually non-trivial. I forgot that I built it by having mapbox handle search entirely in the embed.
I suspect we can get query params working if we have search work as if it where a custom control instead of a default one, but yeah that's not going to be the one liner I was hoping for and instead will make an issue for it.
nevermind, that wasn't that hard. putting up a PR to add url params