CAVaccineInventory / vaccinatethestates

💉🇺🇸 the most comprehensive map of COVID-19 vaccination sites in America

Home Page:https://www.vaccinatethestates.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Map popup links don't handle URLs without http/https in front

al63 opened this issue · comments

This is a sad side effect of poor data quality, but sometimes we have location that have URLs without http or https in front. That means that they will in a tags, assume the link is for vaccinatethestates and will break.

I fixed this problem by prefixing websites without http with // (see site.js), since browsers know to treat that as an external URL. We should port this logic to map popups.

@al63 I'm not sure if this is the issue you are referring to or whether the fix you made to site.js works in this scenario, but here is a screenshot of a vaccination site I found without the HTTP protocol specified in its URL:
Screen Shot 2021-05-21 at 18 37 20

Neither the link to the site in the list under "More details" or in the map points to the correct place: they both attempt to take you to https://www.vaccinatethestates.com/sutterhealth.org.