Problem with new connection checker for ```server_chooser.py```

Question

Problem with new connection checker for ```server_chooser.py```

C0rupted opened this issue 2 years ago · comments

At the moment, the server_chooser.py doesn't work. It says, Invalid Port Number!, even thought the entered port is fine.

github-actions · Answer 1 · Wed Mar 09 2022 19:53:31 GMT+0800 (China Standard Time)

Thanks for reporting your first bug! All help is appreciated!

C0rupted · Answer 2 · Wed Mar 09 2022 20:04:49 GMT+0800 (China Standard Time)

I just did some testing and got the server_chooser.py working, but now when you try to check if the server is online, it just crashes the server, making it think that a new user is trying to connect and that they just sent their username. Anyway, I'm working on a fix now.

C0rupted · Answer 3 · Wed Mar 09 2022 20:05:24 GMT+0800 (China Standard Time)

Creating new dev branch for development before it gets pushed to master

C0rupted · Answer 4 · Wed Mar 09 2022 20:21:33 GMT+0800 (China Standard Time)

I seemed to have found a solution. I'm gonna test everything and then commit to the dev branch.

C0rupted · Answer 5 · Wed Mar 09 2022 20:26:48 GMT+0800 (China Standard Time)

Just pushed commit for the fix in dev branch. Needs further testing though before It can be pushed to master.

C0rupted · Answer 6 · Thu Mar 10 2022 08:03:12 GMT+0800 (China Standard Time)

Looks good, merging dev with master.