0.28 release with PR #72 please?
Pikuseru opened this issue · comments
Pointing to a git commit at the moment, could I please request another 0.28 release for #72 so I can bump our podfile?
thankyou 😄
okay, thankyou - much appreciated btw 😄👍
@Pikuseru Sorry this is taking a while. The Swift Package Manager support and that iOS 13 issue were pretty difficult to tackle.
Could you please test the master branch for me?
If everything works well, I'll release a new version.
I'll schedule some time to take a look this week at master 👍 thanks 😄 It's fine there's no rush - we're all busy 😉
@yvbeek btw did you re-tag 2.9.2 HTTPParserC? Our cocoapods install of my merged PR just went a bit funny, we're looking into what it could be - the HTTPParserC Pods/Target Support Files/HTTPParserC/HTTPParserC.modulemap seems to disappear now, we were originally pointing at 2.9.2 when I check our old podfile.lock from Jan 30, but it looks like 2.9.2 has been tagged at a different commit? (I'm not quite sure - asking to see.)
https://github.com/Building42/HTTPParserC/releases/tag/2.9.2
https://github.com/Building42/HTTPParserC/commits/master
Hi @yvbeek I tried pointing cocoapods at master branch, did a pod install and was able to start the server alright and my UI tests worked so 👍 👍 from me 😄 We did have that separate issue with 2.9.2 tag pointing to another commit, so we changed our develop branch to point to 2.9.0 for the moment - although we'll probably end up bumping to 0.28 to pick up the latest version when you're ready 👍 thanks 😄
Hi @Pikuseru, thank you for testing and sorry for the inconvenience caused by the changes to HTTPParserC. The issues should be resolved now.
Version 0.28 is now available 🚀
Thanks @yvbeek 😄 ⭐️ 🚀