Path Expression When Parameter is Not Last Component

[Justin Kaufman]

This works well to route a profile get request with a trailing 'userid' param:

"/api/v1/profile/:userid"

...but how do I write it when the userid param is in the middle, like:

"/api/v1/:userid/profile"

?

[Yvo van Beek]

Params in the middle should work. In the demo app I tried the following:

If you change line 69 in TelegraphDemo.swift from
server.route(.GET, "hello/:name", serverHandleHello) to
server.route(.GET, "hello/:name/test", serverHandleHello)

Then you should get the following results to these requests:

• https://localhost:9000/hello/bob => 404
• https://localhost:9000/hello/bob/test => 200, "Hello Bob"
• https://localhost:9000/hello/bob/testing => 404

There might be a few edge cases with trailing slashes, because regexes are a bit of pain 🙂

[Justin Kaufman]

I closed this because I got it to work by adding a trailing / at the end of the uri string. If I didn’t have that, then these requests were incorrectly matching on a route that didn’t have the variable param path component.

…

On Jul 3, 2019, at 11:02 AM, Yvo ***@***.***> wrote: Params in the middle should work. In the demo app I tried the following: If you change line 69 in TelegraphDemo.swift from server.route(.GET, "hello/:name", serverHandleHello) to server.route(.GET, "hello/:name/test", serverHandleHello) Then you should get the following results to these requests: https://localhost:9000/hello/bob => 404 https://localhost:9000/hello/bob/test => 200, "Hello Bob" https://localhost:9000/hello/bob/testing => 404 There might be a few edge cases with trailing slashes, because regexes are a bit of pain 🙂 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[Yvo van Beek]

Can you try to add (/) at the end of the route specification?
For example: /api/v1/:userid/profile(/)

That should allow the slash at the end to be optional.

[Justin Kaufman]

@Zyphrax I figured out the cause of the bug.

If the requestor passes an = character in a parameter-type path component (e.g. api/v1/eifjiihgrio=) and you have multiple routes, some with params in the same places (e.g. api/v1/:userid and api/v1/:userid/:pref/ok), none of the associated routes work.

Must be something wrong with the regex parser?

Not a good solution, but to assist w/ debugging, adding this handler fixes the issue:

public class HTTPRequestPathHandler: HTTPRequestHandler {
    public func respond(to request: HTTPRequest, nextHandler: HTTPRequest.Handler) throws -> HTTPResponse? {
        request.uri.path = request.uri.path.replacingOccurrences(of: "=", with: "")
        return try nextHandler(request)
    }
}

[Yvo van Beek]

@JUSTINMKAUFMAN A few minutes ago I pushed a commit with a few changes to HTTPRoute. I've removed some of the validation code to allow more complex paths and special characters.

Can you give the code on the master branch a spin for me?

[Yvo van Beek]

@JUSTINMKAUFMAN Does the commit fix the HTTPRoute issues?

[Justin Kaufman]

@Zyphrax Yes it does, thank you! Looking forward to the next release!

[Yvo van Beek]

@JUSTINMKAUFMAN Version 0.27 is now available! 🎉

[Justin Kaufman]

You’re the best!

…

On Jul 19, 2019, at 1:45 PM, Yvo ***@***.***> wrote: @JUSTINMKAUFMAN Version 0.27 is now available! 🎉 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.