BrowserWorks / Waterfox

The official Waterfox 💧 source code repository

Home Page:https://www.waterfox.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Tabs sidebar causes new tabs to open on the left

turekg opened this issue · comments

What happened?

After the last update to Waterfox (G6.0.12) all new tabs open on the left. This is especially annoying when there are many tabs open and the new tab ends up being hidden. This behavior goes away after disabling the extension.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

G6

What platform are you seeing the problem on?

macOS

Relevant log output

No response

This seems to be related to this issue.

Perhaps but it's not just the links from the tabs in the sidebar, it's all the links from any "regular" tab.

I can't reproduce this on a fresh profile or an existing one. Do you have the same issue in troubleshoot mode?

What means "new tab" in this situation? A blank tab opened by Ctrl-T, or the tab from the "+" button in the horizontal tab bar or the sidebar?

And, in about:config, how configured options browser.newtabpage.enabled, browser.startup.homepage, browser.tabs.insertAfterCurrent and browser.tabs.insertRelatedAfterCurrent?

No I don't have the same issue with troubleshoot mode.
A new tab in this context means when I click on a link on a page which is external to the page's site

A new tab in this context means when I click on a link on a page which is external to the page's site

Thanks! So, in other words the problem you saw is "new tab opened from link always appear just next to the current tab"? Which is the opener tab to reproduce the problem : pinned or unpinned? Or, does the problem appear around both tabs opened from pinned and unpinned tabs?

The problem appears for both pinned and unpinned tabs. The new tab always opens as the first tab on the left.
Additionally, there is another issue: the disabled extension re-enables itself. Cannot pin point what triggers that. The browser is not restarted when it happens. The only clue is that the faulty tab behavior reappears.

The problem appears for both pinned and unpinned tabs. The new tab always opens as the first tab on the left.

So, when you have tabs two like as:

  • A: pinned tab
  • B: unpinned tab

which is the actual result clicking link in the tab A produces:

  • C: new tab from A
  • A: pinned tab
  • B: unpinned tab

or:

  • A: pinned tab
  • C: new tab from A
  • B: unpinned tab

?

And, which is the actual result clicking link in the tab B produces:

  • C: new tab from B
  • A: pinned tab
  • B: unpinned tab

or:

  • A: pinned tab
  • C: new tab from B
  • B: unpinned tab

?

For two tabs like:

A: pinned tab
B: unpinned tab

Clicking link in the tab A produces:

A: pinned tab
C: new tab from A
B: unpinned tab

And clicking link in the tab B produces:

A: pinned tab
C: new tab from B
B: unpinned tab

@turekg Hmm, I still cannot reproduce the problem... Could you collect debug log on the case "C" is opened from "B"? Steps to collect logs:

  1. Click the gear icon in the Waterfox Sidebar and choose "More Settings" with the Shift key.
  2. Detailed options page (TST's options page) is opened in a new tab.
  3. Development => All Configs => click the "Export" button to save a JSON file.
  4. Development => turn the checkbox "Debug mode" on.
  5. Development => turn all checkboxes off under the "Detailed logging" section except "Log with timestamp".
  6. Development => turn following checkboxes on:
    • background/api-tabs-listener
    • background/handle-moved-tabs
    • background/handle-new-tabs
    • background/handle-tab-bunches
    • background/handle-tree-changes
    • background/tabs-move
    • background/tree
  7. Go to about:debugging.
  8. Choose "This Waterfox" in the left sidebar.
  9. Extensions => Tabs Sidebar => Click the "Inspect" button.
  10. A debugger for Tabs Sidebar is opened, so choose the "Console" tab.
  11. Prepare one pinned tab and one unpinned tab in the browser window, like as "A" and "B" in the previous comment.
  12. Click the dustbox icon in the debugger, to clear the console.
  13. Open "C" from the tab "A".
  14. After you see a new tab "C" between "A" and "B", right-click on the console and choose "Save all Messages to File".
  15. Close the tab "C".
  16. Click the dustbox icon in the debugger, to clear the console.
  17. Open "C" (2) from the tab "B".
  18. After you see a new tab "C" (2) between "A" and "B", right-click on the console and choose "Save all Messages to File".
  19. Upload files collected at steps 3, 14 and 18.
  20. Development => turn the checkbox "Debug mode" off to deactivate logging.

This was happening to me. I disabled the new sidebar by setting browser.sidebar.disabled to true in about:config and that fixed it.