Brightspace / frau-publisher

A free-range-app utility for publishing to our CDN.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Feature request: append `appconfig.json` to published to: `url`

mostlyfabulous opened this issue · comments

Could we append appconfig.json to:

' ' + publisher.getLocation() + '\n'

before the \n character?

This would turn the output from: https://s.brightspace.com/apps/d2l-class-stream-app/3.365.0/ to: https://s.brightspace.com/apps/d2l-class-stream-app/3.365.0/appconfig.json.

Unless this format is intentional.

This is just in the console.log that goes into the build output? I think the main reason it's a bit more vague is that frau-publisher is used for both libraries and FRAs. So while FRAs will have an appconfig.json, libraries will not.

This is just in the console.log that goes into the build output?

That's right, makes sense why it is left vague in order to keep it generic.

If there's a way to get the moduletype arg that is passed in, then we could determine whether to append the appconfig.json string and perhaps I could open a PR for that?

frau-publisher --moduletype|-m app|lib

Absolutely yeah -- I think you should be able to check opts.moduleType === 'app'.