Bits of the rewrite not working + causing crashes
tobias76 opened this issue · comments
BlockRegistry - Something to do with the barrels I believe.
OreDictionary - It just doesn't like it at all.
LanguageRegistry - Doesn't cause crashes, just doesn't load the lang files.
Two items have no texture and a name of item.null (Believe they are the beers).
I'm on it
Cheers, also, the two tankards aren't registering even though the drink is.
-----Original Message-----
From: "Arona Jones" notifications@github.com
Sent: 21/02/2015 14:27
To: "warlordjones/FantasyKingdoms" FantasyKingdoms@noreply.github.com
Cc: "Toby" tobyreed0@gmail.com
Subject: Re: [FantasyKingdoms] Bits of the rewrite not working + causingcrashes (#5)
I'm on it
—
Reply to this email directly or view it on GitHub.
So basically you broke everything? >.> :P
Not everything :P the items and potions register! ;)
-----Original Message-----
From: "Arona Jones" notifications@github.com
Sent: 21/02/2015 14:30
To: "warlordjones/FantasyKingdoms" FantasyKingdoms@noreply.github.com
Cc: "Toby" tobyreed0@gmail.com
Subject: Re: [FantasyKingdoms] Bits of the rewrite not working + causingcrashes (#5)
So basically you broke everything? >.> :P
—
Reply to this email directly or view it on GitHub.
I'm going to be fairly blunt, this is a bit of a mess. Could take me a little while
It is fairly rough I'll admit but I'm trying to keep as much out of the main class as possible, however I do believe the fact this is the first run through of the rewrite it is guaranteed to be broken in different places.
I, uh, where did you learn to java?
Primarily trial and error but I have also used multiple books from my local library :P
I think I can tell - no offence intended. Lemme finish off rewriting your rewrite, and everything should work...perhaps learn by example from my code once I push it.
Also, may I suggest that we use my core/lib mod - https://github.com/BrassGoggledCoders/Boilerplate for this mod, and that any features you want in the lib you can contribute to that, instead of making your own coremod?
I think you'll find that I love learning so I will happily take any advice / use your code as an example. I'm happy to use that boilerplate if you think it is beneficial to the progress of the mod :)
Good to hear! I also love learning :D I think its better to have one centeralised lib mod rather than both Boilerplate and MantisCore. I'll add you as a contributor to Boilerplate.
MantisCore was one of the many unfinished ideas I had so it can easily be removed without too much hassle and thankyou (for adding me as a contributor) :D
Stick it all in boilerplate :)
Everything should be functional now