Concave Hull Support
Birdasaur opened this issue · comments
Implement 3D Concave Hull generator that uses Convex Hull (or some other set of points) as input.
Since typically in a non trivial case there will be multiple possible concave hulls derivable from a tolerance variable, make this variable accessible to the user.
Make 3D view that generates a collection of possible Concave Hulls based on a discretization across the tolerance variable.
Let the user select the hull they prefer.
Maybe make it a 3D carousel that rotates for the lulz.
@samypr100
As part of the development done on this branch I've added support for directly ingesting .flac audio files. (previously only .wav was supported) I had to add a new dependency:
<dependency> <groupId>org.jflac</groupId> <artifactId>jflac-codec</artifactId> <version>1.5.2</version> </dependency>
We will need to update the gradle scripts and possibly the YAML for the build actions to match?
We might want to update to the latest versions for the hansolo charts while we are at it but not required.
@Birdasaur Pushed changes to the branch to make it work with gradle and native jpms in 1cb2d98
RE: hansolo, we'll have to support JDK 21 before updating. JDK 21 doesn't work yet with native build.
pulled your build updates. Verified that maven build configurations still work locally. Moved local dev to JDK 21.0.1 etc.
Only current concern is running local build.gradle Jlink target. It currently fails with the following
Task :jlink FAILED
Error: Module jflac.codec does not read a module that exports javax.sound.sampled.spiFAILURE: Build failed with an exception.
- What went wrong:
Execution failed for task ':jlink'.Process 'command 'C:\Users\phillsm1.gradle\jdks\eclipse_adoptium-21-amd64-windows\jdk-21.0.1+12/bin/jlink.exe'' finished with non-zero exit value 1
Gradle build script has:
module('org.jflac:jflac-codec', 'jflac.codec') {
exportAllPackages()
}
haven't had a chance to investigate.
Can you open a draft PR to see if CI fails?
Looks like the Gradle JLink and JPackage builds failed across the OS list.
Clue:
Seems this is the error
Error: Module jflac.codec does not read a module that exports javax.sound.sampled.spi
Likely JDk21 related being more strict, I think we can fix
According to the manifest jflac was compiled using a recent (ish) version of JDK 8.
I pushed an update, let me know if it helps