Biomapas / B.AwsCdkParallel

Enables parallel stack deployments for AWS CDK tool.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Could we unpin the CDK version in `setup.py`?

phitoduck opened this issue · comments

Hi there,

Would it be possible to un-fix this dependency in the setup.py?

aws-cdk.core>=1.90.0,<=2.0.0

I'm hoping to use this for a newer version of CDK.

I realize that pip install . can take forever with CDK if you don't pin these. Was the reason you pinned them to make the install go faster? I imagine pinning them may help for ensuring that the tests don't go stale either.

If testing is the reason, one alternative could be to add an extra. Maybe something like:

pip install .[test] could cause a particular version range to be fixed--otherwise it would be left loose so this can be install in the same virtual environment as a CDK app using CDK version 2+

Thanks for reading this!

Eric

Hi, you are probably right. There is no real reason for the core module to be here. I removed it with the latest commit: 13567a5. Now the latest version is 3.2.0.