BioPhoton / css-star-rating

Css Star Rating is a css only star rating lib based on best practice UX/UI methodes. It is written in scss and fully customizable.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Build Warning

jlamarr22 opened this issue · comments

I'm submitting a...

[x] Bug report
[ ] Feature request

Current behavior

Build warning occurs when building an app that uses this package with the https://github.com/BioPhoton/angular-star-rating package:

Screen Shot 2019-04-03 at 1 44 23 PM

Screen Shot 2019-04-03 at 1 44 07 PM

Expected behavior

No build warning for invalid animation. This occurs from this line: https://github.com/BioPhoton/css-star-rating/blob/master/dist/scss/_modifiers.scss#L351, which compiles to transition: all none

Current work-around for this is to either:

  • Remove references to css-star-rating package in your app (package.json and wherever you're globally importing it with @import '~css-star-rating/scss/star-rating';) and instead copy the css contained there in to your own file and fix it yourself
  • Or; fork that repo, fix it, and reference that new repo