BioDepot / BioDepot-workflow-builder

:computer: GUI for creating bioinformatics workflows from :whale: Docker containers:

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

W: --force-yes is deprecated, use one of the options starting with --allow instead.

rgschmitz1 opened this issue · comments

It looks like a couple of the Docker files include apt-get --force-yes.

&& apt-get install -y --force-yes --no-install-recommends supervisor \

&& apt-get install -y --force-yes --no-install-recommends supervisor \

This should maybe be replaced with one or more of the --allow flags according to the apt-get man page. We can use --allow-downgrades --allow-remove-essential --allow-change-held-packages instead.

Hmm. OK good catch.

The reason it is there is because in older Ubuntu/Debians it worked to ensure that the Dockerfile could be used for an unattended build (probably to avoid the annoying ask the user for the timezone prompt). It also might be a holdover from a cut and paste since we already have
ENV DEBIAN_FRONTEND="noninteractive" in the Dockerfile

Did you try replacing the old flag with the new ones to see if it built properly?

Hong

Did you try replacing the old flag with the new ones to see if it built properly?

I'm testing out now, I'll report back shortly.

Looks like replacing --force-yes with --allow-downgrades --allow-remove-essential --allow-change-held-packages appears to work. This seems pretty benign, I just thought I'd point it out since I happened to notice it.