BetterDiscord / Installer

A simple standalone program which automates the installation, removal and maintenance of BetterDiscord.

Home Page:https://betterdiscord.app

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace setImmediate with window.focus({raise: true}) in devtools-opened event handler for better cross-platform compatibility

fled-dev opened this issue · comments

commented

Description

The current implementation of the devtools-opened event handler in main.js file of our Electron application uses setImmediate to bring focus back to the main window. However, this approach is not very efficient and may not work properly on some platforms.

To improve the cross-platform compatibility and performance of our application, we should replace setImmediate(() => { window.focus(); }); with window.focus({raise: true}); in the devtools-opened event handler.

This change will ensure that the main window is always brought to the foreground when the DevTools are opened, regardless of the platform. It will also eliminate the need for a callback function, making the code simpler and easier to understand.

Proposed Solution

Replace setImmediate(() => { window.focus(); }); with window.focus({raise: true}); in the devtools-opened event handler in main.js file.

Impact

This change will improve the cross-platform compatibility and performance of our Electron application. It should not have any adverse effects on the functionality or user experience of the application.

References

Electron documentation on window.focus()
Electron documentation on setImmediate()

setImmediate(() => {

I feel like this explanation is insufficient. I see no mention of this in either of the docs you linked, and the option you mentioned doesn't even exist in the linked documentation.