BethanyL / DeepKoopman

neural networks to learn Koopman eigenfunctions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Lstack should use axis=1

ahsteven opened this issue · comments

Hi Bethany,

I noticed a small mistake in FormComplexConjugateBlock

For Lstack you are actually stacking row1 and row2 into columns. The axis for np.stack should actually be =1.

With Axis=2 the Jordan Block becomes [cos, sin; -sin, cos] with axis one it is [cos, -sin; sin cos] which matches the paper.

Edit: Actually I think it may still be correct

Best,

Adam