Cannot compile "master" branch

Question

Cannot compile "master" branch

mc0re opened this issue 3 years ago · comments

🔙 Regression

After fixing the project files to work with VS 2019 (use <Project Sdk="MSBuild.Sdk.Extras/3.0.22">), I get the following errors about abstract methods:

ExoPlayerXamarin\ExoPlayer.SmoothStreaming\obj\Debug\monoandroid90\generated\src\Com.Google.Android.Exoplayer2.Source.Smoothstreaming.Offline.SsDownloadAction.cs(10,30,10,46): error CS0534: 'SsDownloadAction' does not implement inherited abstract member 'DownloadAction.CreateDownloader(DownloaderConstructorHelper)'
ExoPlayerXamarin\ExoPlayer.SmoothStreaming\obj\Debug\monoandroid90\generated\src\Com.Google.Android.Exoplayer2.Source.Smoothstreaming.Offline.SsDownloadHelper.cs(10,30,10,46): error CS0534: 'SsDownloadHelper' does not implement inherited abstract member 'DownloadHelper.GetDownloadAction(byte[], IList)'
ExoPlayerXamarin\ExoPlayer.Dash\obj\Debug\monoandroid90\generated\src\Com.Google.Android.Exoplayer2.Source.Dash.Offline.DashDownloadHelper.cs(10,30,10,48): error CS0534: 'DashDownloadHelper' does not implement inherited abstract member 'DownloadHelper.GetDownloadAction(byte[], IList)'
ExoPlayerXamarin\ExoPlayer.Dash\obj\Debug\monoandroid90\generated\src\Com.Google.Android.Exoplayer2.Source.Dash.Offline.DashDownloadAction.cs(10,30,10,48): error CS0534: 'DashDownloadAction' does not implement inherited abstract member 'DownloadAction.CreateDownloader(DownloaderConstructorHelper)'

Then a couple about bool:

ExoPlayerXamarin\ExoPlayer.UI\obj\Debug\monoandroid90\generated\src\Com.Google.Android.Exoplayer2.UI.DebugTextViewHelper.cs(260,45,260,60): error CS0452: The type 'bool' must be a reference type in order to use it as parameter 'T' in the generic type or method 'Object.GetObject<T>(IntPtr, JniHandleOwnership)'

A bunch about unimplemented interface methods:

ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnLoadingChanged(bool)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnPlaybackParametersChanged(PlaybackParameters)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnPlayerError(ExoPlaybackException)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnRepeatModeChanged(int)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnSeekProcessed()'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnShuffleModeEnabledChanged(bool)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnTimelineChanged(Timeline, Object, int)'
ExoPlayerXamarin\Samples\Cast\PlayerManager.cs(26,54,26,74): error CS0535: 'PlayerManager' does not implement interface member 'IPlayerEventListener.OnTracksChanged(TrackGroupArray, TrackSelectionArray)'

And a few other assorted ones.

Old (and correct) behavior

I guess it was in compilable state some time ago.

Current behavior

Cannot compile.

Reproduction steps

Windows 10, VS 2019 version 16.9.2.

Configuration

Version: master branch

Platform: