Barugon / egui_file

File dialog for egui

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Multiple windows of the same type can not be order-independent

Taywee opened this issue · comments

In something like Bevy, different systems might run in an arbitrary order. For standard egui, Windows have a default ID based on the title, but can be given an explicit ID as well. With egui_file, it is likely that multiple open file dialogs will have the same title and therefore the same ID. This is fine if there is only ever one file dialog, but can cause issues if their order changes, or if the first one stops displaying.

I'm sure there are other considerations, but it seems like the user should be able to set the ID in the case that they expect multiple file dialogs and can't guarantee the order or consistency. Another option would be to let the user pass in their own egui::containers::Window and use that, for instance with a show_custom method that takes in a Window parameter and uses it, then they could customize the window however they like before egui_file uses it.