BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Time range trigger for Multiple Trigger option.

odie1185 opened this issue · comments

Rules

  • I made myself familiar with the README.
  • I checked closed issues for similar ones and did not find a similar feature request mentioned before.
  • I understand that, if insufficient information was provided, my issue will be closed without an answer.

Version

2.20.2

OS

Win 11 Pro 22H2

Device

Legion S7i 16IRH8

Is your feature request related to a problem?

No

How would you like the problem to be solved?

Current LLT Supports a trigger for a specific time, The ability to have a range would be awesome.
Example: between 11 pm and 7 am && When a user becomes active; Do stuff

What alternatives have you considered?

Another approach would be the ability to run an action with the Windows task scheduler

Additional information

No response

This idea isn't bad, the main issue is that currently Actions (or rather the AutomationProcessor) is designed to be even driven and stateless. This means that while a specific time (like 9:00am) is a single event that can trigger a run of Actions, a time range isn't. AutomationProcessor would need to "remember" if it already ran in a given time range, which introduces complexity, like "clearing" it's memory next day, so that it can run again.

I don't see enough value at the moment to make the architecture more complex, just for this, so I am putting this issue on hold.

I understand, thank you for reading and responding. Would running an action with command line be considered? I might be able to achieve the same results with task scheduler.

Command line parameters for LLT were or are something that was/is on the table, but there wasn't much push for it. I will see how much time I have, and consider making one for Actions only - maybe it's a good thing to start with.