WiFi Connect / Disconnect Automation DisplayName is not translatable
Ace-Radom opened this issue · comments
Sichen Lyu commented
Rules
- I made myself familiar with the README.
- I checked closed issues for similar ones and did not find a similar problem mentioned before.
- I understand that, if insufficient information was provided, my issue will be closed without an answer.
Version
2.20.2
OS
Windows 11 23H2
Device
Legion R9000p 2021H
BIOS version
GKCN53WW
What's wrong?
Under [Actions] - [Actions] - [Add new], the names of WiFi Connect / Disconnect Automation are not translatable.
I've confirmed all strings in Crowdin and LenovoLegionToolkit.Lib.Automation\Resources\Resource.resx
. Neither WiFiConnectedAutomationPipelineTrigger.DisplayName
nor WiFiDisconnectedAutomationPipelineTrigger.DisplayName
is stored as a static resource, but directly in code.
How to reproduce the bug?
- Change the language to a non-English language
- Go to [Actions] - [Actions] - [Add new]
- You'll see two string not translated
What is the behavior that you expected?
Should be fixed by #1195.
Logs
I don't think a log is really required for this bug but...anyway
Additional information
This bug was pull-in with #1123.