BartoszCichecki / LenovoLegionToolkit

Lightweight Lenovo Vantage and Hotkeys replacement for Lenovo Legion laptops.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

WiFi Connect / Disconnect Automation DisplayName is not translatable

Ace-Radom opened this issue · comments

Rules

  • I made myself familiar with the README.
  • I checked closed issues for similar ones and did not find a similar problem mentioned before.
  • I understand that, if insufficient information was provided, my issue will be closed without an answer.

Version

2.20.2

OS

Windows 11 23H2

Device

Legion R9000p 2021H

BIOS version

GKCN53WW

What's wrong?

Under [Actions] - [Actions] - [Add new], the names of WiFi Connect / Disconnect Automation are not translatable.

image
image

I've confirmed all strings in Crowdin and LenovoLegionToolkit.Lib.Automation\Resources\Resource.resx. Neither WiFiConnectedAutomationPipelineTrigger.DisplayName nor WiFiDisconnectedAutomationPipelineTrigger.DisplayName is stored as a static resource, but directly in code.

public class WiFiConnectedAutomationPipelineTrigger : IWiFiConnectedPipelineTrigger
{
public string DisplayName => "When WiFi is connected";

public class WiFiDisconnectedAutomationPipelineTrigger : IWiFiDisconnectedPipelineTrigger
{
public string DisplayName => "When WiFi is disconnected";

How to reproduce the bug?

  1. Change the language to a non-English language
  2. Go to [Actions] - [Actions] - [Add new]
  3. You'll see two string not translated

What is the behavior that you expected?

Should be fixed by #1195.

Logs

I don't think a log is really required for this bug but...anyway

log_2024_03_01_09_56_35.txt

Additional information

This bug was pull-in with #1123.