changing tint color of stepper doesn't update the decrease/increate layer (- / +)

Question

changing tint color of stepper doesn't update the decrease/increate layer (- / +)

skibadawid opened this issue 7 years ago · comments

I have put the stepper in a tableViewCell, and for testing purposes every time the cell is show, the tint color is chosen randomly so, so once they go out of view, and come back they will have new color.

After coming back into view.

fix would be to add these into func tintColorDidChange()

increaseLayer.strokeColor = tintColor.cgColor
decreaseLayer.strokeColor = tintColor.cgColor

Patrick Balestra · Answer 1 · Fri Jan 27 2017 02:52:50 GMT+0800 (China Standard Time)

Hey @skibadawid, have you got time to open a PR for this? Let me know if you would be happy to help otherwise I will do it myself 😀

dawid · Answer 2 · Fri Jan 27 2017 03:04:10 GMT+0800 (China Standard Time)

yeah of course, probably should have done that originally.

dawid · Answer 3 · Fri Jan 27 2017 03:59:51 GMT+0800 (China Standard Time)

@BalestraPatrick it seems i don't have permission to create a branch with the fix. tried it with both GitHub desktop and terminal.

Patrick Balestra · Answer 4 · Fri Jan 27 2017 06:17:47 GMT+0800 (China Standard Time)

@skibadawid I see you have forked my repo and that's correct. You should now push to your repo the new feature in your master branch. Once that's done, create a PR in my repo based on your master branch. In this way I'll be able to merge your change right away 😄

dawid · Answer 5 · Fri Jan 27 2017 06:26:56 GMT+0800 (China Standard Time)

ahhh ok. thanks for the steps, I'm still a noob with PR and stuff.

Patrick Balestra · Answer 6 · Fri Jan 27 2017 06:29:41 GMT+0800 (China Standard Time)

Don't worry, thanks a lot for taking the time! I just merged it 🙌