Throw exception when the Kernel does not implement KernelInterface

Question

Throw exception when the Kernel does not implement KernelInterface

shyim opened this issue a year ago · comments

It took me some time to understand that your Kernel needs to implement KernelInterface. It would be much easier when you would throw just an exception when the requirements are not met.

Is there some reason why it currently has an fallback?

https://github.com/Baldinof/roadrunner-bundle/blob/2.x/src/Runtime/Runtime.php#L19

Florent Baldino · Answer 1 · Fri May 05 2023 16:41:05 GMT+0800 (China Standard Time)

Hello,

I would accept a PR to throw when RR_MODE is set but the kernel is not app is not a KernelInterface.

How did you land in that case?

Shyim · Answer 2 · Fri May 05 2023 16:47:45 GMT+0800 (China Standard Time)

We do crazy stuff with Symfony Kernels also wrapping them up 😅
https://github.com/shopware/recipes/blob/main/shopware/core/6.4/public/index.php#L53

I will make later a PR :)

Florent Baldino · Answer 3 · Fri May 05 2023 17:54:05 GMT+0800 (China Standard Time)

Ahah alright, the kernel is only required to retrieve the WorkerRegistryInterface in the runner.

I would also accept something that decouple the runner from the KernelInterface if it can helps.