BIGBALLON / CIFAR-ZOO

PyTorch implementation of CNNs for CIFAR benchmark

Typo in SummaryWriter?

arkhodamoradi opened this issue 5 years ago · comments

Alireza Khodamoradi commented 5 years ago

Hello,

Should "log_dir" change to "logdir" at here: https://github.com/BIGBALLON/CIFAR-ZOO/blob/master/train.py#L133

WILL LEE commented 5 years ago

Hi, @arkhodamoradi
the latest commit of tensorboardX use logdir
https://github.com/lanpa/tensorboardX/blob/e9323109eab780a7444508e95f9d3a49e1f4f59f/tensorboardX/writer.py#L192

while the old version of tensorboardX used log_dir.
https://github.com/lanpa/tensorboardX/blob/a15266e177c876d654f1062c37d0cf93abb7920f/tensorboardX/writer.py#L246

and I will update my code for the latest commit.

Alireza Khodamoradi commented 5 years ago

Thanks for the quick response.