Azure / azure-signalr

Azure SignalR Service SDK for .NET

Home Page:https://aka.ms/signalr-service

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade dependency on Microsoft.Rest.ClientRuntime to Azure.Core

timjansenortec opened this issue · comments

Describe the bug

Microsoft.Azure.SignalR and Microsoft.Azure.SignalR.Management packages depend on Microsoft.Rest.ClientRuntime.
This package is now deprecated: https://www.nuget.org/packages/Microsoft.Rest.ClientRuntime/
Microsoft.Rest.ClientRuntime will no longer receive security fixes after September 2023.
The dependency should probably be updated to Azure.Core.

To Reproduce

Exceptions (if any)

Further technical details

  • Your Azure SignalR SDK version
  • Your Server ASPNETCORE version or Assembly version of Microsoft.AspNetCore.SignalR
  • Your SignalR Client SDK version

I was checking if we are supposed to use a different package, but 'Get started' documentation is still guiding to use Microsoft.Azure.SignalR.
see https://learn.microsoft.com/en-us/azure/azure-signalr/signalr-quickstart-dotnet-core#add-azure-signalr-to-the-web-app

commented

@vicancy We use Microsoft.Rest.ClientRuntime package for generated REST client, which is only used for health check API. Should we remove the generated client and roll back to the hand-written client?

@vicancy We use Microsoft.Rest.ClientRuntime package for generated REST client, which is only used for health check API. Should we remove the generated client and roll back to the hand-written client?

sounds good enough using a simple httpclient

any progress on removing this deprecated dependency??