Remove the auto-close PR bot
tombuildsstuff opened this issue · comments
Whilst I can understand the desire to close stale PR’s, unfortunately that Service Teams aren’t actively reviewing PR’s leads to a pretty hostile contribution experience with the auto-close bot.
A few examples:
I’d suggest removing the auto-close PR bot, since it’s pretty user-hostile - or at least providing an external means of escalating PR’s if the Service Teams don’t have time to review them.
Two of the three examples above could be repro’d by using the API, so I’m not sure why the Service Team needs to be involved specifically there?
Since the ask here is about the auto-close PR bot and not any particular Azure Service. I am removing the CXP attention label and adding the Service attention label on this.
@akning-ms Could you please check and add the right label to notify the service team that looks into this ?
@tombuildsstuff , thanks for your feedback. I understand the situation from service team. Currently, if a PR doesn't have any activity more than 14 days, then bot would mark it as stale and send email notification but wouldn't close this PR. PR assignee will be supposed to coordinate the PR review and merge.
One thing we will improve is to notify PR author by teams so that it can be more timely.
Let us know what's your feedback.
Hi, we're sending this friendly reminder because we haven't heard back from you in a while. We need more information about this issue to help address it. Please be sure to give us your input within the next 7 days. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!
This is still waiting on a response from the ARM Team imo
Sent a PR to fix this in #21538
x-linking: #21845 (comment)
@navba-MSFT @raych1 @JackTn here's the latest example of where this is causing issues: #25142 (comment) - is there a timeline for this to be fixed?
@navba-MSFT @raych1 @JackTn yet another example: #25435 (comment)