Giters

Azure / azure-functions-eventgrid-extension

EventGrid extension for Azure Functions

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix code issues

mathewc opened this issue · comments

commented

In reviewing a recent PR, I saw a bunch of stuff which should be fixed:

  • many files missing file headers
  • EventGridListener should not be public. Some other types are public as well which should probably not be (e.g. SubscriptionValidationResponse)
  • EventGridTriggerAttribute should be in the Microsoft.Azure.WebJobs namespace. See all other binding attributes for comparison. This would be a breaking change for v1, but we should fix for v2
  • In the v2.x branch, the file EventGridEvent contains 2 types that seem completely unrelated. Are those types even used anymore?
commented

Closing as it is no longer applicable