Giters

Azure / Azure-Verified-Modules

Azure Verified Modules (AVM) is an initiative to consolidate and set the standards for what a good Infrastructure-as-Code module looks like. Modules will then align to these standards, across languages (Bicep, Terraform etc.) and will then be classified as AVMs and available from their respective language specific registries.

Home Page:https://aka.ms/AVM

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Module Proposal]: `avm/ptn/monitoring/amba`

arjenhuitema opened this issue · comments

commented

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/monitoring/amba

Module Details

Pattern module for AMBA

Do you want to be the owner of this module?

Yes

Module Owner's GitHub Username (handle)

arjenhuitema

(Optional) Secondary Module Owner's GitHub Username (handle)

JoeyBarnes

commented

@arjenhuitema, thank you for proposing this module! As this is categorized as a pattern module, its approval will require a more thorough assessment. The AVM core team will get back to you soon. Thank you for your patience!

commented

Adding more information. Please le me know if there's anything else.

Name: avm/ptn/monitoring/amba
Display Name: Azure Monitor Baseline Alerts (AMBA)

  • What is it for? It provides customers with a monitoring module that implements monitoring holistically using AMBA provided best practices.

  • Resource vs Pattern? This should be a pattern module as it deploys multiple resources.

  • List of resources that would be part of the planned module. The pattern module will at a minimum use one or more of the following:

    • MetricAlerts
    • ActivityLogAlerts
    • ScheduledQueryAlerts
    • ActionGroups
    • AlertProcessingRules

  • Where is it coming from/what’s backing it? This comes from Azure Monitor Baseline Alerts, a Microsoft managed project:

  • Comparing AMBA and AMBA-ALZ module proposals:

    • AMBA: This module should be deployed together with other pattern/resource modules. It uses AMBA guidance to create alerts and other resources based on the resources that are being deployed.
    • AMBA-ALZ: Deploys the AMBA-ALZ pattern, which includes deployment and assignment of Policies, Initiatives, and other resources.
commented

Thanks, @arjenhuitema, for your patience, everything looks great, let's continue with our standard "handshake" process!

commented

Hi @arjenhuitema,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

commented

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

commented

Hi @arjenhuitema,

Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!

Before starting development, please ensure ALL the following requirements are met.

Please use the following values explicitly as provided in the module index page:

  • For your module:
    • ModuleName - for naming your module
    • TelemetryIdPrefix - for your module's telemetry
  • For your module's repository:
    • Repo name and folder path are defined in RepoURL
    • Create GitHub teams for module owners and contributors and grant them permissions as outlined here.
    • Grant permissions for the AVM core team and PG teams on your GitHub repo as described here.

Check if this module exists in the other IaC language. If so, collaborate with the other owner for consistency. 👍

You can now start the development of this module! ✅ Happy coding! 🎉

Please respond to this comment and request a review from the AVM core team once your module is ready to be published! Please include a link pointing to your PR, once available. 🙏

Any further questions or clarifications needed, let us know!

Thanks,

The AVM Core Team