Azure / ARO-RP

Found this when following prepare a shared rp development

When I have $RESOURCEGROUP that's longer than 15 characters, it's truncated to 15 in deploy/env-development.json when provisioning the KVs. Below is an example from deploy/env-development.json:

        {
            "name": "[concat(concat(take(resourceGroup().name,15), '-sharedKV'), '/add')]",
            "type": "Microsoft.KeyVault/vaults/accessPolicies",

But when running make runlocal-rp, I'd get errors saying it couldn't find the provisioned KVs. This is because the code currently truncates the name to just 14 characters. Here is the location in the code

ARO-RP/pkg/util/cluster/cluster.go

Line 184 in 4dbe573

kvName = vnetResourceGroup[:14] + generator.SharedKeyVaultNameSuffix

Off by one error resource group name truncation during shared dev provisioning