usage of replace function disallows dollar signs in paths
spustlik opened this issue · comments
spustlik commented
if i try to copy from folder myfolder to $$$temp$$$\myfolder, it will fail,
because string.replace function interprets second parameter and replaces $$ to $ (for example).
it is easy to fix - just instead of
var target = link.replace(currentPath, targetPath);
call
var target = link.replace(currentPath, function () { return targetPath; });
thank you
Jose V. Trigueros commented
Super bump on this, I came all the way from node-webkit-builder because I was getting an error where a file with double $ wasn't being copied over. I could not identify where the issue was until I dug further. Please accept @spustlik 's PR all the tests pass 👍
Anthony Raymond commented
I would like to have that too