userchrome.js exception in private mode
orency opened this issue · comments
The Addressbar redux v4 in latest userchrome.js can cause some bug in private mode on firefox 117.
when i open firefox in normal mode,everthing works fine.however when i open a private mode window, the url input tool bar can not pop up some suggestions and search engine chooses any more.
And meanwhile i can not use enter to finish input , only way is use mouse to click right arrow in input bar can work.
This unnormal phenomenon will continue happen even if private mode window been closed, unless i close firefox and open it again in normal mode then it will work normally.
I have tried delete Addressbar redux v4 in userchrome.js,then everything back to normal.So i guess the origin of this problem should in this function.
It is indeed broken.
I have an unpublished version that is close to what I expected, just need to test it a bit.
@orency,
pushed Addressbar redux v5, you are gonna like it!
- navigate to input on Enter
if input contains dot, and not contains space - otherwise do default (search) - search for input on Tab
automatically quotes URLs - like before, this only happens on the first entry
using arrow keys to select another entry uses default Tab action
This is how I imagined it the first time, but never got to fully implement it.
As a bonus, this bypasses a lot of search telemetry that firefox uses / sells (less so on forks).