AvdLee / appstoreconnect-swift-sdk

The Swift SDK to work with the App Store Connect API from Apple.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

There are duplicate parameter values in app_store_connect_api_2.0_openapi.json

hmhv opened this issue · comments

commented

I found some duplicate parameter values in app_store_connect_api_2.0_openapi.json.

for example with path /v1/ciProducts/{id}/app, there are two fields[inAppPurchases].
And there is one fieldsInAppPurchases In generated swift code PathsV1CiProductsWithIDApp.swift

public var fieldsInAppPurchases: [FieldsInAppPurchases]?

    "/v1/ciProducts/{id}/app" : {
      "get" : {
        "tags" : [ "CiProducts" ],
        "operationId" : "ciProducts-app-get_to_one_related",
        "parameters" : [ {
          "name" : "fields[betaLicenseAgreements]",
          "in" : "query",
          "description" : "the fields to include for returned resources of type betaLicenseAgreements",
          "schema" : {
            "type" : "array",
            "items" : {
              "type" : "string",
              "enum" : [ "agreementText", "app" ]
            }
          },
          "style" : "form",
          "explode" : false

...

        }, {
          "name" : "fields[inAppPurchases]",
          "in" : "query",
          "description" : "the fields to include for returned resources of type inAppPurchases",
          "schema" : {
            "type" : "array",
            "items" : {
              "type" : "string",
              "enum" : [ "apps", "inAppPurchaseType", "productId", "referenceName", "state" ]
            }
          },
          "style" : "form",
          "explode" : false
        }, {

....

        }, {
          "name" : "fields[inAppPurchases]",
          "in" : "query",
          "description" : "the fields to include for returned resources of type inAppPurchases",
          "schema" : {
            "type" : "array",
            "items" : {
              "type" : "string",
              "enum" : [ "app", "appStoreReviewScreenshot", "availableInAllTerritories", "content", "contentHosting", "familySharable", "iapPriceSchedule", "inAppPurchaseLocalizations", "inAppPurchaseType", "name", "pricePoints", "productId", "promotedPurchase", "reviewNote", "state" ]
            }
          },
          "style" : "form",
          "explode" : false
        }, {

Here is All wrong info i know.

	-attribute paths.'/v1/apps'(get).parameters.There are duplicate parameter values
	-attribute paths.'/v1/ciProducts/{id}/app'(get).parameters.There are duplicate parameter values
	-attribute paths.'/v1/apps/{id}'(get).parameters.There are duplicate parameter values
	-attribute paths.'/v2/inAppPurchases/{id}'(get).operationId is repeated

Thanks for reporting in! I'm not sure how much I can do to fix this since the OpenAPI specs are delivered by Apple. Is there anything that doesn't work for you due to this? If not, I would like to close this issue since I can't do much about it.

Correct me if I'm wrong, I might misunderstand your report!

commented

Thank you for your response. you can close this issue.