is_outlier - returns true when it's not an outlier
andrew404 opened this issue · comments
Hey,
Was just perusing your code, looking to learn more about HRV data cleanup, classifying and cleaning ectopic beats etc...
I stared at this code for like 15 minutes scratching my head until I realized...
Did you misname your is_outlier method, or do I not understand your code?
It looks like, even from the description that is_outlier returns true on a valid RR-interval... i.e. not an outlier?
In remove_ectopic_beats you are testing is_outlier, then only inmcrementing outlier count if its false.
Anyways, if I was correct here, you might want to clean it up for readability.
Thanks, and thanks for sharing your code!!
hrv-analysis/hrvanalysis/preprocessing.py
Line 149 in 285019a