Make name of MusicTrackManager public
misteu opened this issue · comments
Description
When I want to somehow identify music tracks on an AppleSequencer
I need to build this / keep track of it myself. There is already a name
property but for some reason it's fileprivate
:
fileprivate var name: String = "Unnamed"
What it the reason for it being fileprivate
? Can't we just make it usable for identification purposes?
Proposed Solution
Change fileprivate var name: String = "Unnamed"
in MusicTrack.swift
to public var name: String = "Unnamed"
Describe Alternatives You've Considered
Building my own wrapper for adding some id / name field.
Additional Context
No response
I'm sure that would be fine. I would make it open var
to match the other variables in the class. Can you submit a PR?
Yes sure :) makes sense to make it open
like the others!
Alright, I will open a small PR later tonight.
Thanks for merging!