Atcold / NYU-DLSP20

NYU Deep Learning Spring 2020

Home Page:https://atcold.github.io/NYU-DLSP20/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[FA] Default RTL

Atcold opened this issue · comments

Farsi should default to RTL.
@ebetica can you please take care of this?

I've tried to apply RTL to farsi in my local repo and everything was fine except that inline math is not rendered correctly, I'm not sure if this is something that should be handled in MD file or in html.
image

@Alireza1044 can you please check if the Arabic version looks alright?
How did you apply RTL to your local repo?
Also, please circle what's wrong and add a screenshot with the English version, so that we better understand what's going on.

@Atcold The Arabic translation looks right because they didn't put math expressions in $$ in their markdown files.
I changed line 12 in pytorch-Deep-Learning/docs/jekyllbook/_layouts/default.html file to apply RTL to Farsi in my local repo.
image
In the below screen shot you can see that the math expressions are messed up.
photo_2020-09-23 20 48 49

The image below is the English version. They are in the week06/06-2.md file.
Screen Shot 2020-09-23 at 20 50 54

Then, what do you suggest? Can you figure a way to fix this locally?

I don't know much about web developing and how to handle these things, But I think there's a way to render math expressions in LTR and the rest of the text in RTL.

As you can see below math expressions are not an exception and are rendered like the rest of the text:
image

After a slight change in the md file (the <div dir="ltr"> tag which I added before $$) to force this part to be rendered in LTR:
image

The output is like this:
image

But this trick won't work with inline math expressions (As you can see in the picture below), But I suppose there is a way to make an exception for math expressions. I think an expert in web programming should help us here.
94335850-3af8c200-ffeb-11ea-891e-1ac0c0f49921

image