Asana / python-asana

Official Python client library for the Asana API v1

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Relax dependency on requests-oauthlib

adamhowardprice opened this issue · comments

In your requirements.txt you depend on requests_oauthlib>=0.8.0<2.0, but in your setup.py, it says:

install_requires=[
        'requests >= 2.20.0, == 2.*',
        'requests_oauthlib >= 0.8.0, == 0.8.*',
        'six >= 1.10, == 1.*'
    ],

Why is there a difference between the two? This is forcing our project to use 0.8.0, which makes using this library impossible, because another dependency requires requests-oauthlib>=1.0.0.

commented

I just ran into this issue. It is breaking a build for me.

Thank you @w8s for the PR. I merged it in. If either of you can't use the repo version and need a new release asap, let me know. Otherwise I'll do the release in early january.

EDIT: Actually our automated builds are working. I'll go ahead and push a patch release now.

commented

Thanks so much for the quick response and resolution! I will test tomorrow and let you know.

Thanks @rossgrambo ! Will you be deploying this release to PyPi soon?

commented

Echoing @adamhowardprice: What is the ETA on releasing 0.9.2 to PyPi? Appreciate the prompt patching, @rossgrambo. 🙌

Build failed without bumping the version. Went ahead and bumped and redeployed. I see it on PyPi now! Let me know if either you have any have issues!

commented

That fixed my issue. Thanks!