ArxOne / MrAdvice

.NET aspect weaver (build task under NuGet package)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AssemblyName starting with "Microsoft." skipped by Mr.Advice

gregrata opened this issue · comments

If the projects AssemblyName starts with "Microsoft.", and a method is decorated with a Advice attribute, the Advise method is never called. Renaming to something else (e.g., "Microsoft2." works

Looks like it's in IsSystem():

return prefix == "System" || prefix == "Microsoft";

"System." is probably reasonable. Not sure about Microsoft (and it's blocking me). I'm not familiar with the code base or why that's in there - would removing it be best, or add some kind of option to allow for it?

I need to take a look at it, and I will soon.

I wrote the poor man’s fix and just removed Microsoft. from exclusion.